1115295 - [Stingray][AppDeck/Home] Empty folders are not removed correctly in cardManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

When there are several empty folders, cardManager wouldn't remove them
correctly after calling writeCardlistInCardStore(). Some of them keep remained.

We also need to send card-removed event when empty folders are removed.
To handle situations that several folders are removed at once, we may need
to change argument passed to callback on card-removed such that multiple
folders can be removed at once.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Working on it

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

We could send `card-removed` event with detail of multiple indices of cardlist

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: WIP for cardManager

The work in progress.
Since Tzu-lin is doing refactoring, this is just for reference.

It also includes some modification to allow inserting card/folder on specified position.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Another issue is that DETACHED folders are still written to database in the topmost cardList.
(Although they don't generate new folder entries)
We need to write cardList to database *after* excluding empty folders.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: WIP for cardManager

Sorry I slightly changed it a bit.
I found that it would be better to let user specify if it has to clean-up empty folders, otherwise rearranging would also cause empty folders to be cleaned.
This is the WIP for reference.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Rex,

I made a patch based on the WIP you provided (https://bug1115295.bugzilla.mozilla.org/attachment.cgi?id=8541398).

Please help to review it, thanks.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8542887 [details] [review]
pull request

Looks good to me with some comments.

Thanks for the work!

Comment 8

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Thanks,

I modified commit message as commented and rebased the patch to latest master.

Waiting fo Gaia-Try result
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=3bcc50c668e1

Comment 9

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Landed on master 
https://github.com/mozilla-b2g/gaia/commit/3e56f24a0eaf2e95f3f438748290a9b2c877db7f